Fix search providers icons #41432
Merged
Fix search providers icons #41432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
Altahrim
requested review from
a team,
ArtificialOwl,
icewind1991,
sorbaugh,
Fenn-CS and
emoral435
and removed request for
a team
|
CI failure unrelated |
Merged
come-nc
reviewed
Nov 14, 2023
| @@ -221,6 +221,10 @@ private function fetchIcon(string $appId, string $providerId): string { | |||
| [$appId, 'app.svg'], | |||
| ['core', 'places/default-app-icon.svg'], | |||
| ]; | |||
| if ($appId === 'settings' && $providerId === 'users') { | |||
| // The file /apps/settings/users.svg if already used in black version by user menu | |||
There was a problem hiding this comment.
Suggested change
| // The file /apps/settings/users.svg if already used in black version by user menu | |
| // The file /apps/settings/users.svg is already used in black version by user menu |
Typo maybe? Or I do not understand the comment.
But still I do not understand the comment I think.
There was a problem hiding this comment.
Yes, typo…
We are using /apps/settings/users.svg as an icon in the user menu on top right. In the menu, we need a black icon.
But for search, we need a white version.
There was a problem hiding this comment.
Must these icons have the same name? Can't both colors be present? to avoid this?
There was a problem hiding this comment.
Must these icons have the same name?
My hack avoid this. The new icon is white and we keep the old one
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
Altahrim
force-pushed
the
fix/white-user-icon-search
branch
from
cf11ebe
to
79d1e40
Compare
come-nc
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to advanced search