implements search on null/notnull metadata

[ArtificialOwl]

Add the possiblity to search on null/not null value on metadata.
This is a test-feature for the Photos App.

This PR requires to add this line

      '{DAV:}is-defined'    => Operator::class,

in https://github.com/nextcloud/3rdparty/blob/master/icewind/searchdav/src/DAV/QueryParser.php#L78

[...]
     <d:where>
        <d:and>
          <d:not>
          <d:is-defined>
            <d:prop><nc:metadata-test/></d:prop>
            </d:is-defined>
          </d:not>
        </d:and>
[...]

Need:

• Add handling for is-defined operator icewind1991/SearchDAV#13
• Bump icewind/searchdav to 3.1.0 in master 3rdparty#1643

[artonge]

Nice

[icewind1991]

might be cleaner to just transform the dav operator to field == null !(field == null) instead of adding a new search operator

[artonge]

might be cleaner to just transform the dav operator to field == null !(field == null) instead of adding a new search operator

Do you mean in the DAV request ? The issue is that we are casting the type of the property here:

server/apps/dav/lib/Files/FileSearchBackend.php

Lines 418 to 436 in b79a21d

	private function castValue(SearchPropertyDefinition $property, $value) {
	switch ($property->dataType) {
	case SearchPropertyDefinition::DATATYPE_BOOLEAN:
	return $value === 'yes';
	case SearchPropertyDefinition::DATATYPE_DECIMAL:
	case SearchPropertyDefinition::DATATYPE_INTEGER:
	case SearchPropertyDefinition::DATATYPE_NONNEGATIVE_INTEGER:
	return 0 + $value;
	case SearchPropertyDefinition::DATATYPE_DATETIME:
	if (is_numeric($value)) {
	return max(0, 0 + $value);
	}
	$date = \DateTime::createFromFormat(\DateTimeInterface::ATOM, (string)$value);
	return ($date instanceof \DateTime && $date->getTimestamp() !== false) ? $date->getTimestamp() : 0;
	default:
	return $value;
	}
	}

And as the property is used in another comparison in the request, it is assumed to be an integer. So using the appropriate operator would be cleaner I think.

[artonge]

Pushed 3rdparty changes

[ChristophWurst]

👍 for the caldav changes

[ArtificialOwl]

Working on fixing test.
Since commit ..., the array returned in the response is reordered:

• "name": "{DAV:}href",
• "name": "{DAV:}propstat",
• "name": "{DAV:}status",

(status was before propstat before)

[ChristophWurst]

adds new public API -> needs docs