Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move delete share button into the scrolling container #41489

Merged
merged 1 commit into from Nov 15, 2023
Merged

Move delete share button into the scrolling container #41489

merged 1 commit into from Nov 15, 2023

Conversation

JuliaKirschenheuter
Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter commented Nov 15, 2023 •
edited by AndyScherzinger

Summary

Before:

Peek 2023-11-15 12-08

After:

Peek 2023-11-15 13-52

Checklist

@JuliaKirschenheuter JuliaKirschenheuter added the 3. to review Waiting for reviews label Nov 15, 2023
@JuliaKirschenheuter JuliaKirschenheuter self-assigned this Nov 15, 2023
@JuliaKirschenheuter JuliaKirschenheuter force-pushed the fix/41463-Move_delete_share_button_into_the_scrolling_container branch from 0f116c7 to 0fa64be Compare November 15, 2023 12:50
@JuliaKirschenheuter
Copy link
Contributor Author

/compile fixup /

@JuliaKirschenheuter
Move delete share button into the scrolling container
9d9fffb 
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
@JuliaKirschenheuter JuliaKirschenheuter force-pushed the fix/41463-Move_delete_share_button_into_the_scrolling_container branch from d41a4e2 to 9d9fffb Compare November 15, 2023 16:11
@susnux
Copy link
Contributor

susnux commented Nov 15, 2023

Drone unrelated

@susnux susnux disabled auto-merge November 15, 2023 18:24
@susnux susnux merged commit 8bda5e9 into master Nov 15, 2023
40 of 41 checks passed
@susnux susnux deleted the fix/41463-Move_delete_share_button_into_the_scrolling_container branch November 15, 2023 18:24
@AndyScherzinger AndyScherzinger added this to the Nextcloud 28 milestone Nov 15, 2023
@blizzz blizzz mentioned this pull request Nov 16, 2023
Merged
@jancborchardt jancborchardt mentioned this pull request Nov 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jancborchardt jancborchardt jancborchardt approved these changes

@ShGKme ShGKme ShGKme approved these changes

@susnux susnux Awaiting requested review from susnux

@Fenn-CS Fenn-CS Awaiting requested review from Fenn-CS

@Pytal Pytal Awaiting requested review from Pytal

@szaimen szaimen Awaiting requested review from szaimen

Assignees

@JuliaKirschenheuter JuliaKirschenheuter

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.

[BITV]: Move delete share button into the scrolling container
5 participants
@JuliaKirschenheuter @susnux @jancborchardt @ShGKme @AndyScherzinger