fix(userstatus): Only track message timestamp for values #41512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristophWurst
requested review from
nickvergessen,
st3iny,
miaulalala and
Antreesy
Merged
nickvergessen
approved these changes
Nov 16, 2023
Do not track status messages that are empty, e.g. DND outside of availability. Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
force-pushed
the
fix/userstatus/no-message-no-message-timestamp
branch
from
882827e
to
bdad290
Compare
Antreesy
approved these changes
Nov 16, 2023
blizzz
added
4. to release
ChristophWurst
deleted the
fix/userstatus/no-message-no-message-timestamp
branch
5 tasks
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Do not track status messages that are empty, e.g. DND outside of availability.
How to test
master: ", seconds ago" shows for the main user
here: no status update is shown on the dashboard because the user didn't change their status.
Checklist