New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix upload of folders in Chrome #4153

Merged
merged 1 commit into from Apr 6, 2017

Conversation

Projects
None yet
5 participants
@MorrisJobke
Member

MorrisJobke commented Mar 29, 2017

  • this fixes the problem with the uploads of folders in Chrome, that you noticed
  • thanks for @georgehrke for helping to fix this
  • @karlitschek I will backport this to stable11 as well
@mention-bot

This comment has been minimized.

mention-bot commented Mar 29, 2017

@MorrisJobke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @butonic, @luckydonald and @vincchan to be potential reviewers.

@MorrisJobke

This comment has been minimized.

Member

MorrisJobke commented Mar 29, 2017

I tested this and it fixes the issue. 👍

@MorrisJobke

This comment has been minimized.

Member

MorrisJobke commented Mar 29, 2017

Backport is in #4154

@MorrisJobke

This comment has been minimized.

Member

MorrisJobke commented Mar 30, 2017

@georgehrke Could I ask you to look into fixing the unit tests for this? That would be nice. Thanks :) (feel free to take over those two PRs, because I will be not available Thursday and Friday)

@karlitschek

This comment has been minimized.

Member

karlitschek commented Mar 30, 2017

great. please backport

@nickvergessen

This comment has been minimized.

Member

nickvergessen commented Mar 30, 2017

What does this actually fix? Because I uploaded folders just fine this week on the latest chromium and nextcloud?

@nickvergessen

FAILED
TypeError: undefined is not an object (evaluating 'this._uploads[data.uploadId].data = data') in apps/files/js/file-upload.js (line 541)
getUpload@apps/files/js/file-upload.js:541:32
fail@apps/files/js/file-upload.js:897:33
_trigger@core/vendor/jquery-ui/ui/jquery-ui.custom.js:789:18
add@apps/files/js/file-upload.js:850:18
apps/files/tests/js/fileUploadSpec.js:72:41
collect@core/vendor/underscore/underscore.js:172:32
addFiles@apps/files/tests/js/fileUploadSpec.js:63:15
apps/files/tests/js/fileUploadSpec.js:103:21

@MorrisJobke

This comment has been minimized.

Member

MorrisJobke commented Apr 3, 2017

@georgehrke @ChristophWurst @nextcloud/javascript Could one of you help with the JS unit tests? That would be nice :)

Fix upload of folders in Chrome
Signed-off-by: Morris Jobke <hey@morrisjobke.de>

I fixed the tests

@MorrisJobke

This comment has been minimized.

Member

MorrisJobke commented Apr 6, 2017

@LukasReschke @georgehrke @rullzer @nickvergessen Please re-review - I fixed it

@rullzer

rullzer approved these changes Apr 6, 2017

Fine by me... altough I could not reproduce the original issue....

@nickvergessen nickvergessen merged commit 287bae8 into master Apr 6, 2017

1 of 2 checks passed

continuous-integration/drone/pr the build failed
Details
Scrutinizer No new issues
Details

@nickvergessen nickvergessen deleted the fix-upload branch Apr 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment