Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(files): make files list valid table layout #41577

Merged
merged 2 commits into from Nov 17, 2023

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Nov 17, 2023

Error: Start tag div seen in table.
Fatal Error: Cannot recover after last error. Any further errors will be ignored.

TODO

  • <caption> must be a direct child of <table>, otherwise it doesn't work
    • Moved to the table
    • Created a new prop for caption to not set it manually as a #before content
  • <div> for a #before is not allowed as a child of <table>
    • Wrapped the current table content in a new table element and made the current root wrapper a div
  • Misc
    • Format files (remove ;)
    • Replace deprecated ::deep with :deep()

Screenshots

Recording.2023-11-17.233217.mp4

Checklist

@ShGKme
Copy link
Contributor Author

ShGKme commented Nov 17, 2023

Still a draft because I'm testing to check if I'm sure that the virtual scrolling is not broken. But ready for review

@ShGKme ShGKme requested a review from Fenn-CS November 17, 2023 16:28
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM at least the "before"-action will be fixed :)

@ShGKme ShGKme marked this pull request as ready for review November 17, 2023 22:35
@ShGKme ShGKme force-pushed the fix/41568/files-list--valid-table-layout branch from e505416 to 1781c94 Compare November 17, 2023 22:35
Otherwise it is not valid and does not ception the table.

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
<div> is not allowed as a <table> child

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme force-pushed the fix/41568/files-list--valid-table-layout branch from 1781c94 to 346c617 Compare November 17, 2023 23:16
@ShGKme ShGKme merged commit ee21204 into master Nov 17, 2023
41 checks passed
@ShGKme ShGKme deleted the fix/41568/files-list--valid-table-layout branch November 17, 2023 23:36
@ShGKme
Copy link
Contributor Author

ShGKme commented Nov 17, 2023

@skjnldsv Sorry for the fast merge, we needed it in master until Monday...

@blizzz blizzz mentioned this pull request Nov 20, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BITV]: Files list table has invalid HTML layout
4 participants