Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update @nextcloud/vue to 8.2.0 #41584

Merged
merged 2 commits into from Nov 17, 2023
Merged

chore: Update @nextcloud/vue to 8.2.0 #41584

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b9133c
chore: Update `@nextcloud/vue` to 8.2.0
susnux Nov 17, 2023
0b55db7
fix(cypress): Adjust user settings tests for changed actions component
susnux Nov 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
40 changes: 20 additions & 20 deletions apps/dav/src/views/__snapshots__/CalDavSettings.spec.js.snap
View file
Open in desktop
Expand Up @@ -82,19 +82,19 @@ exports[`CalDavSettings interactions 1`] = `
/>
<label
class="checkbox-content checkbox-radio-switch__content checkbox-content-switch"
data-v-51c1ef39=""
data-v-9005171d=""
data-v-af4ec574=""
for="caldavSendInvitations"
>
<span
aria-hidden="true"
class="checkbox-content__icon checkbox-content__icon--checked checkbox-radio-switch__icon"
data-v-af4ec574=""
data-v-51c1ef39=""
>
<span
aria-hidden="true"
class="material-design-icon toggle-switch-icon"
data-v-af4ec574=""
data-v-51c1ef39=""
role="img"
>
<svg
Expand All @@ -114,7 +114,7 @@ exports[`CalDavSettings interactions 1`] = `
</span>
<span
class="checkbox-content__text checkbox-radio-switch__text"
data-v-af4ec574=""
data-v-51c1ef39=""
>

Send invitations to attendees
Expand Down Expand Up @@ -154,19 +154,19 @@ exports[`CalDavSettings interactions 1`] = `
/>
<label
class="checkbox-content checkbox-radio-switch__content checkbox-content-switch"
data-v-51c1ef39=""
data-v-9005171d=""
data-v-af4ec574=""
for="caldavGenerateBirthdayCalendar"
>
<span
aria-hidden="true"
class="checkbox-content__icon checkbox-content__icon--checked checkbox-radio-switch__icon"
data-v-af4ec574=""
data-v-51c1ef39=""
>
<span
aria-hidden="true"
class="material-design-icon toggle-switch-icon"
data-v-af4ec574=""
data-v-51c1ef39=""
role="img"
>
<svg
Expand All @@ -186,7 +186,7 @@ exports[`CalDavSettings interactions 1`] = `
</span>
<span
class="checkbox-content__text checkbox-radio-switch__text"
data-v-af4ec574=""
data-v-51c1ef39=""
>

Automatically generate a birthday calendar
Expand Down Expand Up @@ -234,19 +234,19 @@ exports[`CalDavSettings interactions 1`] = `
/>
<label
class="checkbox-content checkbox-radio-switch__content checkbox-content-switch"
data-v-51c1ef39=""
data-v-9005171d=""
data-v-af4ec574=""
for="caldavSendEventReminders"
>
<span
aria-hidden="true"
class="checkbox-content__icon checkbox-content__icon--checked checkbox-radio-switch__icon"
data-v-af4ec574=""
data-v-51c1ef39=""
>
<span
aria-hidden="true"
class="material-design-icon toggle-switch-icon"
data-v-af4ec574=""
data-v-51c1ef39=""
role="img"
>
<svg
Expand All @@ -266,7 +266,7 @@ exports[`CalDavSettings interactions 1`] = `
</span>
<span
class="checkbox-content__text checkbox-radio-switch__text"
data-v-af4ec574=""
data-v-51c1ef39=""
>

Send notifications for events
Expand Down Expand Up @@ -319,19 +319,19 @@ exports[`CalDavSettings interactions 1`] = `
/>
<label
class="checkbox-content checkbox-radio-switch__content checkbox-content-switch"
data-v-51c1ef39=""
data-v-9005171d=""
data-v-af4ec574=""
for="caldavSendEventRemindersToSharedGroupMembers"
>
<span
aria-hidden="true"
class="checkbox-content__icon checkbox-content__icon--checked checkbox-radio-switch__icon"
data-v-af4ec574=""
data-v-51c1ef39=""
>
<span
aria-hidden="true"
class="material-design-icon toggle-switch-icon"
data-v-af4ec574=""
data-v-51c1ef39=""
role="img"
>
<svg
Expand All @@ -351,7 +351,7 @@ exports[`CalDavSettings interactions 1`] = `
</span>
<span
class="checkbox-content__text checkbox-radio-switch__text"
data-v-af4ec574=""
data-v-51c1ef39=""
>

Send reminder notifications to calendar sharees as well
Expand Down Expand Up @@ -388,19 +388,19 @@ exports[`CalDavSettings interactions 1`] = `
/>
<label
class="checkbox-content checkbox-radio-switch__content checkbox-content-switch"
data-v-51c1ef39=""
data-v-9005171d=""
data-v-af4ec574=""
for="caldavSendEventRemindersPush"
>
<span
aria-hidden="true"
class="checkbox-content__icon checkbox-content__icon--checked checkbox-radio-switch__icon"
data-v-af4ec574=""
data-v-51c1ef39=""
>
<span
aria-hidden="true"
class="material-design-icon toggle-switch-icon"
data-v-af4ec574=""
data-v-51c1ef39=""
role="img"
>
<svg
Expand All @@ -420,7 +420,7 @@ exports[`CalDavSettings interactions 1`] = `
</span>
<span
class="checkbox-content__text checkbox-radio-switch__text"
data-v-af4ec574=""
data-v-51c1ef39=""
>

Enable notifications for events via push
Expand Down
1 change: 1 addition & 0 deletions apps/settings/src/views/Users.vue
View file
Open in desktop
Expand Up @@ -97,6 +97,7 @@
{{ t('settings', 'Create group') }}
</NcActionText>
<NcActionInput :label="t('settings', 'Group name')"
data-cy-settings-new-group-name
:label-outside="false"
:disabled="loadingAddGroup"
:value.sync="newGroupName"
Expand Down
10 changes: 5 additions & 5 deletions cypress/e2e/settings/users_groups.cy.ts
View file
Open in desktop
Expand Up @@ -39,15 +39,15 @@ describe('Settings: Create groups', () => {
// open the Create group menu
cy.get('button[aria-label="Create group"]').click()

cy.get('.action-item__popper ul[role="menu"]').within(() => {
cy.get('li[data-cy-settings-new-group-name]').within(() => {
// see that the group name is ""
cy.get('input[placeholder="Group name"]').should('exist').and('have.value', '')
cy.get('input').should('exist').and('have.value', '')
// set the group name to foo
cy.get('input[placeholder="Group name"]').type(groupName)
cy.get('input').type(groupName)
// see that the group name is foo
cy.get('input[placeholder="Group name"]').should('have.value', groupName)
cy.get('input').should('have.value', groupName)
// submit the group name
cy.get('input[placeholder="Group name"] ~ button').click()
cy.get('input ~ button').click()
Comment on lines +42 to +50
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To fix the test, only removing [role="menu"] seems to be required. Then there is no need in data-cy attribute, which uses test less semantic and more coupled on implementation (manually marked place).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would depend on internal implementation (class action-item__popper) which is bad.
So this flags the action where to look on a non implementation dependent way (we set the attribute in our code so we do not rely on the implementation of the action, except for the li element but this is required due to a bug with actions (the attribute will be assigned on the li tag and also forwarded to the input tag).

})

// Make sure no confirmation modal is shown
Expand Down
0 cypress/e2e/settings/systemtags.cy.ts → cypress/e2e/systemtags/admin-settings.cy.ts
View file
Open in desktop
File renamed without changes.
4 changes: 2 additions & 2 deletions dist/4107-4107.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/4107-4107.js.map
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions dist/5823-5823.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/5823-5823.js.map
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions dist/6318-6318.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/6318-6318.js.map
View file
Open in desktop

Large diffs are not rendered by default.