Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

accept boolean value #41655

Merged
merged 1 commit into from Nov 22, 2023
Merged

accept boolean value #41655

merged 1 commit into from Nov 22, 2023

Conversation

ArtificialOwl
Copy link
Member

@ArtificialOwl ArtificialOwl commented Nov 22, 2023 •
edited

fix #41630

@ArtificialOwl
accept boolean value
ff823cf 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
@ArtificialOwl ArtificialOwl requested review from a team, icewind1991, Fenn-CS and sorbaugh and removed request for a team November 22, 2023 02:35
@ArtificialOwl ArtificialOwl added this to the Nextcloud 28 milestone Nov 22, 2023
@ArtificialOwl ArtificialOwl added the 3. to review Waiting for reviews label Nov 22, 2023
@juliushaertl juliushaertl merged commit f79398c into master Nov 22, 2023
50 checks passed
@juliushaertl juliushaertl deleted the fix/41630/search-value-bool branch November 22, 2023 07:50
@nickvergessen
Copy link
Member

If only we could add a test similar to

server/build/integration/features/dav-v2.feature

Lines 84 to 88 in 5f90b8e

Scenario: Create a search query
Given using new dav path
And As an "admin"
When User "user0" uploads file "data/green-square-256.png" to "/image.png"
When Image search should work
to ensure this never breaks again :)

@AndyScherzinger
Copy link
Member

@ArtificialOwl could you please add a test as suggested #41655 (comment) - thanks in advance! 👍

@blizzz blizzz mentioned this pull request Nov 22, 2023
Merged
5 tasks
@ArtificialOwl ArtificialOwl mentioned this pull request Nov 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@juliushaertl juliushaertl juliushaertl approved these changes

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 was automatically assigned from nextcloud/server-backend

@Fenn-CS Fenn-CS Awaiting requested review from Fenn-CS Fenn-CS was automatically assigned from nextcloud/server-backend

@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh was automatically assigned from nextcloud/server-backend

@artonge artonge Awaiting requested review from artonge

@come-nc come-nc Awaiting requested review from come-nc

Assignees
No one assigned
Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.

[Bug]: Invalid type for field favorite
4 participants
@ArtificialOwl @nickvergessen @AndyScherzinger @juliushaertl