New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always emit search event #41771
Always emit search event #41771
Conversation
@@ -248,9 +248,8 @@ export default { | |||
this.results = [] | |||
return | |||
} | |||
if (this.supportFiltering()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also drop the method?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@juliushaertl the method is needed to make sure the "Filter in app" button for our own hard coded apps, show for now.
33f07a5
to
aa66016
Compare
/backport to stable28 |
For BOD, it's better to always emit the search event so apps (all of which we don't know) responding to this effect would receive notifications when the search happens within these apps. Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
aa66016
to
e99d7ba
Compare
/backport to stable28 |
For BOD, it's better to always emit the search event so apps (all of which we don't know) responding to this effect would receive notifications when the search happens within these apps.