[stable27] Improve share logic for enforced password & expiry date #41936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fenn-CS
added
4. to release
Fenn-CS
force-pushed
the
41885-27-manual-backport
branch
from
b84bcde
to
05300c6
Compare
Fenn-CS
requested review from
AndyScherzinger,
susnux,
juliushaertl,
artonge and
Pytal
AndyScherzinger
approved these changes
Nov 30, 2023
artonge
approved these changes
Nov 30, 2023
In order to meet accessibility requirements we cannot use a sticky footer that overlaps important interactable content. Therefore this moves to a scroll container for the details which does not include the action buttons at the bottom. Larger indentation change in SharingDetailsTab was required to have a wrapping container for the scroll area. Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Fenn-CS
force-pushed
the
41885-27-manual-backport
branch
from
05300c6
to
728618c
Compare
|
/compile amend / |
* It's possible for the admin to enforce and expiry date after, some shares have been created. This commit makes possible to update the share with the new admin constraints. * This commit would users to modify enforced expiry to anything within range and less than the enforced limit in the pre-create dialog for public shares. * This commit fixes, unable to update share without updating password. Signed-off-by: fenn-cs <fenn25.fn@gmail.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-command
force-pushed
the
41885-27-manual-backport
branch
from
728618c
to
8c5ea73
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual backport #41885
Also included :
These other pr's are included because they were never backported and now the current backport is much more difficult due to not-easy-to-resolve conflicts