Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(files): drag and drop #42366

Merged
merged 3 commits into from
Dec 20, 2023
Merged

fix(files): drag and drop #42366

merged 3 commits into from
Dec 20, 2023

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Dec 19, 2023

Fix #42252
Fix #42136
Fix #42252

@skjnldsv skjnldsv added bug 2. developing Work in progress labels Dec 19, 2023
@skjnldsv skjnldsv requested a review from susnux December 19, 2023 08:48
@skjnldsv skjnldsv self-assigned this Dec 19, 2023
@skjnldsv skjnldsv added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Dec 20, 2023
@skjnldsv skjnldsv added this to In progress in Files to vue via automation Dec 20, 2023
@skjnldsv skjnldsv added this to the Nextcloud 28.0.2 milestone Dec 20, 2023
@skjnldsv skjnldsv requested review from a team, Fenn-CS and sorbaugh and removed request for a team December 20, 2023 08:28
@skjnldsv skjnldsv changed the title fix(files): recursive drop path join fix(files): drag and drop Dec 20, 2023
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 20, 2023
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv skjnldsv merged commit aae9960 into master Dec 20, 2023
42 checks passed
@skjnldsv skjnldsv deleted the fix/dragdrop-join branch December 20, 2023 16:42
Files to vue automation moved this from In progress to Done Dec 20, 2023
@skjnldsv
Copy link
Member Author

/backport to stable28

@backportbot-nextcloud
Copy link

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b fix/foo-stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable28

Error: Unknown error

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@skjnldsv
Copy link
Member Author

/backport dbfd8f6 to stable28

@backportbot-nextcloud
Copy link

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b fix/foo-stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable28

Error: Unknown error

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@HLFH
Copy link
Contributor

HLFH commented Jan 25, 2024

Fixed on Chrome but not on Safari. No? @skjnldsv

@HLFH
Copy link
Contributor

HLFH commented Jan 25, 2024

It is still broken on Safari. #43135

@stefano99
Copy link

stefano99 commented Mar 16, 2024

It's still broken on V28 and Firefox too.
On Edge is working almost perfectly, just a file failed but was uploaded correctly on second try.

(same installation, same client machine, only the browser is different)

@bfrmtx
Copy link

bfrmtx commented Jun 2, 2024

On Arch Linux:
Chrome 125.0.6422.141 broken
Firefox 126.0.1 broken
Falkon 24.05.0 broken

@susnux
Copy link
Contributor

susnux commented Jun 2, 2024

@bfrmtx please open a new issue for this with more information (use the template on issue creation).
Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: files
Projects
Files to vue
  
Done
Development

Successfully merging this pull request may close these issues.

[Bug]: drag&drop upload of folder fails [Bug]: Drag&Drop is broken on NC28rc4 again
7 participants