Remove display name ellipsis in user menu #42402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jerome-Herbinet
added
design
jancborchardt
requested changes
Dec 20, 2023
There was a problem hiding this comment.
This leads to the width of the menu extending infinitely though depending on the name:
I suggest using a higher value for the max-width. Either a set one (208px works well in English) or if possible to just use whichever space is available in the menu. But not to extend the width of the menu. :)
Jerome-Herbinet
force-pushed
the
Jerome-Herbinet-remove-full-name-ellipsis-in-user-menu
branch
from
a818238
to
1e1f940
Compare
jancborchardt
approved these changes
Dec 21, 2023
|
There is a conflict ; what's the easiest way for me to solve it ? |
Jerome-Herbinet
force-pushed
the
Jerome-Herbinet-remove-full-name-ellipsis-in-user-menu
branch
2 times, most recently
from
9bd9138
to
8d21e7c
Compare
|
Hello everyone :) @szaimen & @jancborchardt : Should @Jerome-Herbinet update the branch with rebase (please, look at the screenshot)? I worked with him this morning and we rebased his branch.
|
szaimen
force-pushed
the
Jerome-Herbinet-remove-full-name-ellipsis-in-user-menu
branch
from
8d21e7c
to
8898d97
Compare
Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com> Update UserMenu.vue Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com> npm run build Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com> Revert with a higher max-width value Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
szaimen
force-pushed
the
Jerome-Herbinet-remove-full-name-ellipsis-in-user-menu
branch
from
8898d97
to
02e2c69
Compare
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
|
/backport 02e2c69 to stable28 |
|
CI failure unrelated |
szaimen
deleted the
Jerome-Herbinet-remove-full-name-ellipsis-in-user-menu
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #42455
Screenshots made with NC 28.0.1 RC1
Before
After
Checklist