Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable28] fix: Ensure app menu entries and dashboard welcome message have enough contrast #42403

Merged
merged 2 commits into from Dec 21, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion apps/dashboard/src/DashboardApp.vue
Expand Up @@ -465,7 +465,8 @@ export default {
background-attachment: fixed;

> h2 {
color: var(--color-primary-element-text);
// this is shown directly on the background which has `color-primary`, so we need `color-primary-text`
color: var(--color-primary-text);
text-align: center;
font-size: 32px;
line-height: 130%;
Expand Down
8 changes: 5 additions & 3 deletions core/src/components/AppMenu.vue
Expand Up @@ -160,7 +160,7 @@ $header-icon-size: 20px;
width: 12px;
height: 5px;
border-radius: 3px;
background-color: var(--color-primary-element-text);
background-color: var(--color-primary-text);
left: 50%;
bottom: 6px;
display: block;
Expand All @@ -177,7 +177,8 @@ $header-icon-size: 20px;
width: calc(100% - 4px);
height: calc(100% - 4px);
margin: 2px;
color: var(--color-primary-element-text);
// this is shown directly on the background which has `color-primary`, so we need `color-primary-text`
color: var(--color-primary-text);
position: relative;
}

Expand All @@ -194,7 +195,8 @@ $header-icon-size: 20px;
opacity: 0;
position: absolute;
font-size: 12px;
color: var(--color-primary-element-text);
// this is shown directly on the background which has `color-primary`, so we need `color-primary-text`
color: var(--color-primary-text);
text-align: center;
left: 50%;
top: 45%;
Expand Down
4 changes: 2 additions & 2 deletions dist/core-main.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/core-main.js.map

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions dist/dashboard-main.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/dashboard-main.js.map

Large diffs are not rendered by default.