Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(files): Adjust ID for skip content buttons #42419

Merged
merged 1 commit into from Dec 21, 2023
Merged

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Dec 21, 2023

Summary

As we now use Vue the ID needs to be adjusted.

Checklist

@susnux
Copy link
Contributor Author

susnux commented Dec 21, 2023

/backport to stable28

Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Main content may have ids:

  1. #app-content-vue in Vue apps from rendered as NcAppContent, usually used in full Vue apps with rendered as NcContent with navigation and sidebar (Talk, Photos, Activity, Users settings, Apps settings) and in Files (there is NcAppContent but no NcContent).
  2. Set in Template via id-app-content. By default, it is #app-content for user and #content for public, but can be custom set via id-app-content property. Used by not full Vue apps (not NcContent apps), for example, any page in Personal or Admin settings, Help, Public share.

Skip links always uses the ID from p.2.

This PR fixes the issue for Files app but doesn't fix the issue in general. For example, Photos app, Activity app.

I think we should have a solution that fixes Skip links in a common way, otherwise we need to fix it in each app separately and have no control over it.

@susnux
Copy link
Contributor Author

susnux commented Dec 21, 2023

think we should have a solution that fixes Skip links in a common way, otherwise we need to fix it in each app separately and have no control over it.

I know this is just the first quick fix. I currently prepare a more general fix on the vue library.

Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A common solution from @nextcloud/vue will work for general apps like Photos, Activity or Talk.

This PR is needed because Files app has more complex mounting with NcAppContent but without NcContent by manual mounting of content, navigation, and sidebar.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux merged commit b919eb4 into master Dec 21, 2023
50 checks passed
@susnux susnux deleted the fix/skip-buttons-files branch December 21, 2023 14:55
@susnux
Copy link
Contributor Author

susnux commented Dec 21, 2023

/backport to stable28

@backportbot-nextcloud
Copy link

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b fix/foo-stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable28

Error: Unknown error

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@backportbot-nextcloud
Copy link

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b fix/foo-stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable28

Error: Unknown error

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@blizzz blizzz mentioned this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BITV]: Skip links are not working anymore
5 participants