Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(files): focus file name on renaming also initially #42443

Merged

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Dec 22, 2023

Summary

When a new folder is created, the new file entry is initially in renaming mode
Watch should handle renaming not only on change, but also on init.

Screenshots

Before After
new-folder-before new-folder-after

Checklist

@ShGKme
Copy link
Contributor Author

ShGKme commented Dec 22, 2023

/backport to stable28

Copy link
Contributor

@emoral435 emoral435 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works, and LGTM! Nice use of deep handlers :)

@ShGKme
Copy link
Contributor Author

ShGKme commented Dec 22, 2023

Drone error seems related

@susnux
Copy link
Contributor

susnux commented Dec 23, 2023

Drone error seems related

Yes

@ShGKme ShGKme added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Dec 24, 2023
@ShGKme ShGKme marked this pull request as draft December 24, 2023 20:29
When new folder is created, new file entry is initially in renaming mode.

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme force-pushed the fix/41876/files--focus-file-name-on-new-folder-rename branch from aaf5b11 to b6a9387 Compare January 2, 2024 16:32
@ShGKme
Copy link
Contributor Author

ShGKme commented Jan 2, 2024

Drone error seems related

It was not related 👀

@ShGKme
Copy link
Contributor Author

ShGKme commented Jan 2, 2024

No changes, just rebased onto master. All test passes now

@ShGKme ShGKme marked this pull request as ready for review January 2, 2024 16:54
@ShGKme ShGKme added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jan 2, 2024
@ShGKme ShGKme enabled auto-merge January 2, 2024 16:55
@ShGKme ShGKme merged commit 2218897 into master Jan 2, 2024
44 checks passed
@ShGKme ShGKme deleted the fix/41876/files--focus-file-name-on-new-folder-rename branch January 2, 2024 16:55
@backportbot-nextcloud
Copy link

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b fix/foo-stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable28

Error: Unknown error

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants