Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(systemreport): Mark more configs as sensitive #42658

Merged
merged 2 commits into from Jan 11, 2024

Conversation

nickvergessen
Copy link
Member

cc @isdnfan

Checklist

@nickvergessen nickvergessen added bug 3. to review Waiting for reviews labels Jan 9, 2024
@nickvergessen nickvergessen added this to the Nextcloud 29 milestone Jan 9, 2024
@nickvergessen nickvergessen self-assigned this Jan 9, 2024
@nickvergessen
Copy link
Member Author

/backport to stable28

@nickvergessen
Copy link
Member Author

/backport to stable27

@nickvergessen
Copy link
Member Author

/backport to stable26

Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but didnt test

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the bugfix/42530/mark-more-configs-as-sensitive branch from 1ea4d0a to 6294f0f Compare January 9, 2024 12:08
@nickvergessen nickvergessen merged commit cfd1cc5 into master Jan 11, 2024
49 of 50 checks passed
@nickvergessen nickvergessen deleted the bugfix/42530/mark-more-configs-as-sensitive branch January 11, 2024 11:33
@backportbot-nextcloud
Copy link

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b fix/foo-stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable28

Error: Unknown error

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@backportbot-nextcloud
Copy link

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b fix/foo-stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

Error: Unknown error

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@backportbot-nextcloud
Copy link

The backport to stable26 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable26
git pull origin stable26

# Create the new backport branch
git checkout -b fix/foo-stable26

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26

Error: Unknown error

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@skjnldsv
Copy link
Member

/skjnldsv-backport to stable28

@skjnldsv
Copy link
Member

/skjnldsv-backport to stable27

@skjnldsv
Copy link
Member

/skjnldsv-backport to stable26

Copy link

backportbot bot commented Jan 15, 2024

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b backport/42658/stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 6294f0f4bc81318f1af38308367d4bf87ecd6877 4e8e598662434a133bc1f0d2b034dfc171c81eb9

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/42658/stable28

Error: erreur : aucun picorage ou retour en cours
fatal : le picorage a échoué


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Copy link

backportbot bot commented Jan 15, 2024

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b backport/42658/stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 6294f0f4bc81318f1af38308367d4bf87ecd6877 4e8e598662434a133bc1f0d2b034dfc171c81eb9

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/42658/stable27

Error: erreur : aucun picorage ou retour en cours
fatal : le picorage a échoué


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Copy link

backportbot bot commented Jan 15, 2024

The backport to stable26 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable26
git pull origin stable26

# Create the new backport branch
git checkout -b backport/42658/stable26

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 6294f0f4bc81318f1af38308367d4bf87ecd6877 4e8e598662434a133bc1f0d2b034dfc171c81eb9

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/42658/stable26

Error: erreur : aucun picorage ou retour en cours
fatal : le picorage a échoué


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@nickvergessen
Copy link
Member Author

/skjnldsv-backport 6294f0f to stable28

@nickvergessen
Copy link
Member Author

/skjnldsv-backport 6294f0f to stable27

@nickvergessen
Copy link
Member Author

/skjnldsv-backport 6294f0f to stable26

@skjnldsv

This comment was marked as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: generate system report doesn't remove all sensitive values
5 participants