fix(quota): automatically detect chunk quota with OC-Total-Length header
#42679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skjnldsv
requested review from
icewind1991,
juliushaertl,
artonge and
come-nc
This was referenced Jan 10, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| * the quota on the target destination. | ||
| * | ||
| * @param string $source source path | ||
| * @param string $destination destination path | ||
| */ | ||
| public function beforeMove($source, $destination) { | ||
| $sourceNode = $this->server->tree->getNodeForPath($source); | ||
| public function beforeMove(string $sourcePath, string $destinationPath) { |
Check notice
Code scanning / Psalm
MissingReturnType Note
skjnldsv
force-pushed
the
fix/chunked-quota
branch
from
2bd0861
to
13d7051
Compare
…eader Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
skjnldsv
force-pushed
the
fix/chunked-quota
branch
from
13d7051
to
9703b1d
Compare
come-nc
approved these changes
Jan 11, 2024
juliushaertl
approved these changes
Jan 11, 2024
skjnldsv
added
the
pending documentation
skjnldsv
removed
the
pending documentation
|
Docs update nextcloud/documentation#11432 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When uploading chunks, legacy old methods had a dedicated
oc-chunkedheader which is NOT used anymoreThere was some specific name pattern to follow and the new chunk uploading is much simpler
Solution
Because we also send the
OC-Total-Lengthheader, we can actually check the quota from the first uploaded chunk.Results
With nextcloud-libraries/nextcloud-upload#1042
Fix #40702