fix(admin role): fix old and wrong way to determine whether user is admin #42706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
8 tasks
|
/backport to stable28 |
blizzz
added
2. developing
blizzz
force-pushed
the
fix/42480/user-admin-not-admin
branch
from
4987393
to
ed89474
Compare
blizzz
added
3. to review
blizzz
requested review from
come-nc,
a team,
ArtificialOwl and
Altahrim
and removed request for
a team
come-nc
approved these changes
Jan 15, 2024
Altahrim
approved these changes
Feb 19, 2024
…dmin - fixes Settings knowing who is an admin of non-local group backend groups - obsoletes and removes a little old, deprecated code - double checks proper parameter type on Group\Manager::isAdmin - also fixes legacy OC_User code to check whether user is an admin Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
blizzz
force-pushed
the
fix/42480/user-admin-not-admin
branch
from
ed89474
to
c98b046
Compare
skjnldsv
added
4. to release
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
1 task
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The settings app (and potentially others) used legacy code to determine whether a user is an admin, ignoring users of non-local groups whose backend implements
Backend::IS_ADMIN.Checklist