Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enh(OCP\SpeechToText): Introduce ISpeechToTextProviderWithUserId #42761

Merged
merged 5 commits into from Feb 13, 2024
Merged

enh(OCP\SpeechToText): Introduce ISpeechToTextProviderWithUserId #42761

merged 5 commits into from Feb 13, 2024

Conversation

andrey18106
Copy link
Contributor

Summary

To keep consistency between SpeechToText, TextProcessing, Translation and TextToImage providers introduce IProviderWithUserId.

Checklist

@andrey18106
Introduce ISpeechToTextProviderWithUserId
13588c7 
Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
@andrey18106 andrey18106 changed the title Introduce ISpeechToTextProviderWithUserId enh(OCP\SpeechToText): Introduce ISpeechToTextProviderWithUserId Jan 14, 2024
@andrey18106
move setting of userId before provider execution
ea7f1f9 
Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
@bigcat88 bigcat88 added this to the Nextcloud 29 milestone Jan 14, 2024
@ChristophWurst ChristophWurst added pending documentation This pull request needs an associated documentation update 4. to release Ready to be released and/or waiting for tests to finish labels Jan 19, 2024
@andrey18106 andrey18106 mentioned this pull request Feb 12, 2024
Merged
@bigcat88 bigcat88 removed the pending documentation This pull request needs an associated documentation update label Feb 13, 2024
@nickvergessen
Copy link
Member

CI is fixed by #43543

@nickvergessen nickvergessen added enhancement pending documentation This pull request needs an associated documentation update labels Feb 13, 2024
@bigcat88
Copy link
Member

documentation already present for this

@nickvergessen
Copy link
Member

Please document in https://docs.nextcloud.com/server/latest/developer_manual/digging_deeper/speech-to-text.html and a short summary in https://docs.nextcloud.com/server/latest/developer_manual/app_publishing_maintenance/app_upgrade_guide/upgrade_to_29.html#id1

@nickvergessen nickvergessen merged commit f2a7bfd into master Feb 13, 2024
153 of 156 checks passed
@nickvergessen nickvergessen deleted the enh/speech-to-text-provider-with-userid branch February 13, 2024 08:35
@nickvergessen
Copy link
Member

documentation already present for this

I see the PR, but not the change on the live page.... maybe building broke?

@nickvergessen
Copy link
Member

At least in https://docs.nextcloud.com/server/latest/developer_manual/app_publishing_maintenance/app_upgrade_guide/upgrade_to_29.html#id1 it should still be added with a link to the normal docs

@nickvergessen
Copy link
Member

I see the PR, but not the change on the live page.... maybe building broke?

Ah, merged 1h ago :D

@blizzz blizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelklehr marcelklehr marcelklehr approved these changes

@bigcat88 bigcat88 bigcat88 approved these changes

@juliushaertl juliushaertl Awaiting requested review from juliushaertl

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement pending documentation This pull request needs an associated documentation update
Projects
None yet
Milestone
Nextcloud 29
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@andrey18106 @nickvergessen @bigcat88 @marcelklehr @ChristophWurst