Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enh(a11y): improved contrast on user menu #42856

Merged
merged 2 commits into from Jan 17, 2024

Conversation

emoral435
Copy link
Contributor

Summary

Changed the color of the span elements within the user menu - this made it so that the first user link had the incorrect color for its text!

New look on dark / light theme

firefox_cSAcAyYyLl|firefox_18lgSLKWZZ

Checklist

Signed-off-by: Eduardo Morales <emoral435@gmail.com>
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
@emoral435 emoral435 force-pushed the fix/a11y/42688/menu-items-contrasts-are-not-enough branch from d241533 to 865b340 Compare January 16, 2024 19:47
@emoral435
Copy link
Contributor Author

/skjnldsv-backport bdb75b2 to stable28

@blizzz blizzz mentioned this pull request Jan 17, 2024
@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 17, 2024
@Pytal Pytal merged commit efe3551 into master Jan 17, 2024
42 checks passed
@Pytal Pytal deleted the fix/a11y/42688/menu-items-contrasts-are-not-enough branch January 17, 2024 18:36
@blizzz blizzz mentioned this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish accessibility enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BITV]: Menu item contrasts are not enough
3 participants