fix(build): Do not generated OpenAPI for non-shipped apps or apps without OpenAPI support #42923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hout OpenAPI support Signed-off-by: provokateurin <kate@provokateurin.de>
provokateurin
requested review from
nickvergessen,
julien-nc,
bigcat88 and
andrey18106
provokateurin
requested review from
ChristophWurst,
miaulalala and
st3iny
as code owners
ChristophWurst
approved these changes
Jan 18, 2024
|
/skjnldsv-backport to stable28 |
andrey18106
approved these changes
Jan 18, 2024
|
Thx for the super fast reviews! |
nickvergessen
approved these changes
Jan 18, 2024
There was a problem hiding this comment.
Resources are not supported atm, but we should fix the app later
1 task
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Improves the detection (e.g. systemtags was previously forgotten) and skips apps that are not shipped (which are potentially not compatible with the current openapi-extractor version).
Checklist