New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(files): fixed aria-desciption logic for last breadcrumb #42950
Merged
skjnldsv
merged 1 commit into
master
from
fix/a11y/41895/breadcrumb-fix-for-home-component
Jan 20, 2024
Merged
fix(files): fixed aria-desciption logic for last breadcrumb #42950
skjnldsv
merged 1 commit into
master
from
fix/a11y/41895/breadcrumb-fix-for-home-component
Jan 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emoral435
requested review from
susnux,
JuliaKirschenheuter,
Pytal and
ShGKme
January 18, 2024 23:49
emoral435
force-pushed
the
fix/a11y/41895/breadcrumb-fix-for-home-component
branch
from
January 18, 2024 23:50
ceb5f77
to
fa29df4
Compare
ShGKme
requested changes
Jan 18, 2024
emoral435
force-pushed
the
fix/a11y/41895/breadcrumb-fix-for-home-component
branch
2 times, most recently
from
January 19, 2024 00:52
dbfbbd0
to
ea765cf
Compare
Seems @szaimen checked with German where it is not translated so no issue code-wise |
indeed, looks like it... |
Pytal
changed the title
fix(files): fixed home aria-label and desc logic
fix(files): fixed home desc logic
Jan 19, 2024
Pytal
approved these changes
Jan 19, 2024
emoral435
changed the title
fix(files): fixed home desc logic
fix(files): fixed aria-desc logic
Jan 19, 2024
emoral435
changed the title
fix(files): fixed aria-desc logic
fix(files): fixed aria-desciption logic for last breadcrumb
Jan 19, 2024
/compile / |
This comment was marked as resolved.
This comment was marked as resolved.
/backport to stable28 |
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
skjnldsv
force-pushed
the
fix/a11y/41895/breadcrumb-fix-for-home-component
branch
from
January 20, 2024 12:05
df22929
to
81057f6
Compare
skjnldsv
added
the
4. to release
Ready to be released and/or waiting for tests to finish
label
Jan 20, 2024
skjnldsv
approved these changes
Jan 20, 2024
2 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Cleaned up the aria-description logic a bit!
Screenshots for the new changes
Checklist