Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(files): fixed aria-desciption logic for last breadcrumb #42950

Merged
merged 1 commit into from Jan 20, 2024

Conversation

emoral435
Copy link
Contributor

@emoral435 emoral435 commented Jan 18, 2024

Summary

Cleaned up the aria-description logic a bit!

Screenshots for the new changes

image

Checklist

@emoral435 emoral435 added this to the Nextcloud 29 milestone Jan 18, 2024
@emoral435 emoral435 self-assigned this Jan 18, 2024
@emoral435 emoral435 force-pushed the fix/a11y/41895/breadcrumb-fix-for-home-component branch from ceb5f77 to fa29df4 Compare January 18, 2024 23:50
apps/files/src/components/BreadCrumbs.vue Outdated Show resolved Hide resolved
@emoral435 emoral435 force-pushed the fix/a11y/41895/breadcrumb-fix-for-home-component branch 2 times, most recently from dbfbbd0 to ea765cf Compare January 19, 2024 00:52
@Pytal
Copy link
Member

Pytal commented Jan 19, 2024

I just checked on master and it is already translated correctly 💡

image

@Pytal
Copy link
Member

Pytal commented Jan 19, 2024

Seems @szaimen checked with German where it is not translated so no issue code-wise

@szaimen
Copy link
Contributor

szaimen commented Jan 19, 2024

Seems @szaimen checked with German where it is not translated so no issue code-wise

indeed, looks like it...

@emoral435
Copy link
Contributor Author

@Pytal @ShGKme I still propose that this PR get merged. Upon checking the master branch, it appears that the last breadcrumb doesn't have that aria-description that we proposed to keep :/

image

This PR still fixes that! Updated the main summary for the PR though

@emoral435 emoral435 requested a review from ShGKme January 19, 2024 13:40
@Pytal Pytal changed the title fix(files): fixed home aria-label and desc logic fix(files): fixed home desc logic Jan 19, 2024
@Pytal Pytal requested a review from skjnldsv January 19, 2024 18:50
@emoral435 emoral435 changed the title fix(files): fixed home desc logic fix(files): fixed aria-desc logic Jan 19, 2024
@emoral435 emoral435 changed the title fix(files): fixed aria-desc logic fix(files): fixed aria-desciption logic for last breadcrumb Jan 19, 2024
@emoral435
Copy link
Contributor Author

/compile /

@emoral435

This comment was marked as resolved.

@skjnldsv
Copy link
Member

/backport to stable28

Signed-off-by: Eduardo Morales <emoral435@gmail.com>
@skjnldsv skjnldsv force-pushed the fix/a11y/41895/breadcrumb-fix-for-home-component branch from df22929 to 81057f6 Compare January 20, 2024 12:05
@skjnldsv skjnldsv removed the 3. to review Waiting for reviews label Jan 20, 2024
@skjnldsv skjnldsv added the 4. to release Ready to be released and/or waiting for tests to finish label Jan 20, 2024
@skjnldsv skjnldsv merged commit fd73d3a into master Jan 20, 2024
38 of 41 checks passed
@skjnldsv skjnldsv deleted the fix/a11y/41895/breadcrumb-fix-for-home-component branch January 20, 2024 12:21
@blizzz blizzz mentioned this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish accessibility bug
Projects
None yet
5 participants