Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable28] fix(theming): Apply same logic on capabilities for primary color as done on themes #43032

Merged
merged 1 commit into from Jan 23, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jan 22, 2024

Summary

On themes we replace the default color with the accessible color, so we also need to do this on the capabilities.
This worked previously but as we now enforce contrasts of the text color clients that use the capabilities changes to black text on that color.

Checklist

@susnux susnux added this to the Nextcloud 28.0.2 milestone Jan 22, 2024
@susnux susnux changed the title [stable28] fix(theming): Apply same logic on capabilities for primary color like on themes [stable28] fix(theming): Apply same logic on capabilities for primary color as done on themes Jan 22, 2024
@provokateurin provokateurin removed their request for review January 22, 2024 17:54
@SystemKeeper
Copy link
Contributor

For my understanding, why not adjust this in

public function getTextColorPrimary() {
return $this->util->invertTextColor($this->getColorPrimary()) ? '#000000' : '#ffffff';
}

🤔

@susnux
Copy link
Contributor Author

susnux commented Jan 22, 2024

For my understanding, why not adjust this in

Better would be in getColorPrimary, but that would have greater consequences especially for a stable branch I would not change that API and just fix the usage here.

For a general fix I currently prepare this one: #42977

@sorbaugh sorbaugh mentioned this pull request Jan 22, 2024
@blizzz

This comment was marked as resolved.

@susnux susnux force-pushed the fix/stable28-capabilities branch 2 times, most recently from f70a37b to d2d5e7d Compare January 22, 2024 19:53
@blizzz

This comment was marked as resolved.

… on themes

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 23, 2024
@susnux
Copy link
Contributor Author

susnux commented Jan 23, 2024

cypress unrelated

@blizzz blizzz merged commit 667b0bc into stable28 Jan 23, 2024
48 of 51 checks passed
@blizzz blizzz deleted the fix/stable28-capabilities branch January 23, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: theming
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants