Bump NcVue to v8.6.2
#43438
Merged
Bump NcVue to v8.6.2
#43438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JuliaKirschenheuter
requested review from
st3iny,
susnux,
skjnldsv,
Pytal,
ShGKme and
emoral435
susnux
reviewed
Feb 7, 2024
| @@ -4231,6 +4231,18 @@ | |||
| "npm": "^9.0.0" | |||
| } | |||
| }, | |||
| "node_modules/@nextcloud/vue/node_modules/@nextcloud/router": { | |||
There was a problem hiding this comment.
Now doubling the dependencies of router, might be bad. Can we update @nextcoud/router for server in the package.json as well? So we only use one version.
There was a problem hiding this comment.
Then we need to update it literally everywhere. @nextcloud/axios, @nextcloud/dialogs, @nextcloud/files, @nextcloud/password-confirmation, @nextcloud/upload
Let's only update the @nextcloud/vue first. @nextcloud/router is stateless and small, should not be an issue.
Then we can update all the dependencies
ShGKme
approved these changes
Feb 7, 2024
Pytal
approved these changes
Feb 7, 2024
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
Pytal
force-pushed
the
bump/bump-ncvue-to-v8.6.2
branch
from
5a34c4c
to
f63f18b
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump NcVue to
v8.6.2