Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(settings): Disable SSL cert check for JavaScript modules SetupCheck #43558

Closed
wants to merge 1 commit into from

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Feb 13, 2024

Summary

Some users are using self signed certs without adding them as trusted - for this test we can disable the SSL check.

Checklist

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux added bug 3. to review Waiting for reviews labels Feb 13, 2024
@susnux susnux added this to the Nextcloud 29 milestone Feb 13, 2024
@susnux susnux requested review from come-nc, a team, ArtificialOwl and icewind1991 and removed request for a team February 13, 2024 20:44
@susnux
Copy link
Contributor Author

susnux commented Feb 13, 2024

/backport to stable28

Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but didnt test

@susnux

This comment was marked as resolved.

@susnux
Copy link
Contributor Author

susnux commented Feb 15, 2024

Superseded by #43588

@susnux susnux closed this Feb 15, 2024
@susnux susnux deleted the fix/mjs-setup-check branch February 15, 2024 11:52
@skjnldsv skjnldsv removed this from the Nextcloud 29 milestone Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.mjs setup check failing with self-signed certificate
4 participants