Copy the regexes to the public interface

[nickvergessen]

No description provided.

[mention-bot]

@nickvergessen, thanks for your PR! By analyzing the annotation information on this pull request, we identified @LukasReschke, @DeepDiver1975 and @tanghus to be potential reviewers

[MorrisJobke]

👍

[icewind1991]

Wouldn't it be better to have an isUserAgent method (which accepts IRequest::ANDROID, etc) instead of exposing the implentation details of detection

[nickvergessen]

We have a method isUserAgent which accepts an array of regexes. The problem is, you don't have the regexes publicly available to use them on this method.

I would also only consider the name public api, not the actual value?

[MorrisJobke]

I would also only consider the name public api, not the actual value?

Could this be done by an abstract constant? Is this possible?

[ChristophWurst]

I know this is unrelated to your PR, but what about IPv6?

[MorrisJobke]

Open an ticket ;)

[ChristophWurst]

Could this be done by an abstract constant? Is this possible?

No, according to http://php.net/manual/en/language.oop5.interfaces.php:

It's possible for interfaces to have constants. Interface constants works exactly like class constants except they cannot be overridden by a class/interface that inherits them.

[nickvergessen]

I mean we could also add methods that then use isUserAgent(self::CONST) but I prefer those 3 consts over 3 new methods.

[LukasReschke]

👍