Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(styles): Add default styles for disabled elements #43697

Merged
merged 3 commits into from Feb 20, 2024
Merged

fix(styles): Add default styles for disabled elements #43697

merged 3 commits into from Feb 20, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Feb 20, 2024 •
edited

Summary

Add default styles to disabled input elements.

Also replace deprecated variables color-text-light with color-main-text and color-text-lighter with color-text-maxcontrast. The variables are aliases currently but are scheduled for removal.

Screenshots

before after
image image

Checklist

@susnux
fix(styles): Replace deprecated CSS variables
858b4b8 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux added bug design Design, UI, UX, etc. 3. to review Waiting for reviews labels Feb 20, 2024
@susnux susnux changed the title Fix/default inputs style fix(styles): Add default styles for disabled elements Feb 20, 2024
@susnux
fix(styles): Add default styles for disabled input elements
ab424c2 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
chore: Build CSS from SCSS
6a9daa3 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
szaimen
szaimen approved these changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot looks good to me but did not review the code and did not test

@susnux susnux added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 20, 2024
@susnux
Copy link
Contributor Author

susnux commented Feb 20, 2024

/backport to stable28

@susnux susnux added this to the Nextcloud 29 milestone Feb 20, 2024
@susnux susnux self-assigned this Feb 20, 2024
@susnux susnux merged commit 520df67 into master Feb 20, 2024
97 checks passed
@susnux susnux deleted the fix/default-inputs-style branch February 20, 2024 22:30
@backportbot backportbot bot mentioned this pull request Feb 20, 2024
Merged
2 tasks
@ChristophWurst
Copy link
Member

image

👍 thanks!

@blizzz blizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@szaimen szaimen szaimen approved these changes

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@Pytal Pytal Awaiting requested review from Pytal

Assignees

@susnux susnux

Labels
4. to release Ready to be released and/or waiting for tests to finish bug design Design, UI, UX, etc.
Projects
📁 Files team
Archived in project
Milestone
Nextcloud 29
Development

Successfully merging this pull request may close these issues.

[Bug]: Disabled HTML inputs don't appear disabled visually
4 participants
@susnux @ChristophWurst @skjnldsv @szaimen