format current and sync client sessions in Personal #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@icewind1991, thanks for your PR! By analyzing the annotation information on this pull request, we identified @ChristophWurst and @PVince81 to be potential reviewers |
|
👍 nice |
|
Added formatting for most browsers (Fixed mobile chrome to properly say "Google Chrome" after making this screenshot) |
icewind1991
force-pushed
the
sessions-list-format
branch
from
774e77a
to
688b650
Compare
|
Would it be possible to have a tooltip with the full info? Or an 'extra info' thingy or whatever. Sometimes you want to know the exact fingerprint. |
|
Ah nevermind you did that. |
| viewData.name = t('settings', 'Sync client - {os}', { | ||
| os: matches[1], | ||
| version: matches[2] | ||
| }) |
|
Beside the comments above this looks awesome 👍 |
icewind1991
force-pushed
the
sessions-list-format
branch
from
688b650
to
df2dffa
Compare
|
All fixed |
|
Tested and works 👍 |
|
👍 |
|
@icewind1991 you are an awesome dude! :) 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It took me a while to remember what "mirall" was and I doubt any regular user would know without a bit of googling.
This replaces the user agent of sync clients and the current session with a more descriptive name, full user agent can still be found in the tooltip
Before:
After
Further formatting (show nicer browser names instead of their full user agent) can be added at a later date
cc @nextcloud/designers