Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(files): Adjust sidebar - remove deprecated function calls and add aria label for favorite icon #43988

Merged
merged 2 commits into from Mar 5, 2024
Merged

fix(files): Adjust sidebar - remove deprecated function calls and add aria label for favorite icon #43988

merged 2 commits into from Mar 5, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Mar 4, 2024

Summary

  1. Replace some deprecated function calls with the replacement (mostly OC. -> @nextcloud/...).
  2. Replace star symbol with image and proper aria-label for the favorite marker

Checklist

@susnux
fix(files): Remove deprecated function calls from sidebar and add ari…
5995606 
…a-label to favorite icon

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux added this to the Nextcloud 29 milestone Mar 4, 2024
@susnux susnux requested a review from skjnldsv as a code owner March 4, 2024 23:41
@susnux
Copy link
Contributor Author

susnux commented Mar 4, 2024

/backport to stable28

@susnux
Copy link
Contributor Author

susnux commented Mar 4, 2024

/compile amend

@susnux @nextcloud-command
chore: Compile assets
b2610d3 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
JuliaKirschenheuter
JuliaKirschenheuter approved these changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thank you!

ShGKme
ShGKme approved these changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works and fixes a11y issue.

I've noticed one non-comfortable place in the NcAppSidebar - actions if the next element after header, so reading the page in browse mode, you read:

  1. File name
  2. Actions
  3. Close button
  4. Favorite, size, date (aka description for the file from 1)

@skjnldsv skjnldsv merged commit d65e46f into master Mar 5, 2024
96 of 98 checks passed
@skjnldsv skjnldsv deleted the fix/files-favorite branch March 5, 2024 10:51
@backportbot backportbot bot mentioned this pull request Mar 5, 2024
Merged
2 tasks
@blizzz blizzz mentioned this pull request Mar 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JuliaKirschenheuter JuliaKirschenheuter JuliaKirschenheuter approved these changes

@ShGKme ShGKme ShGKme approved these changes

@Pytal Pytal Awaiting requested review from Pytal

@skjnldsv skjnldsv Awaiting requested review from skjnldsv skjnldsv is a code owner

Assignees
No one assigned
Labels
3. to review Waiting for reviews accessibility bug feature: files
Projects
None yet
Milestone
Nextcloud 29
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@susnux @JuliaKirschenheuter @ShGKme @skjnldsv