fix: Avoid clear cache with prefix #43992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliushaertl
requested review from
nickvergessen,
julien-nc,
a team,
ArtificialOwl,
icewind1991 and
Fenn-CS
and removed request for
a team
|
/backport to stable28 |
|
/backport to stable27 |
|
/backport to stable26 |
|
/backport to stable25 |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
juliushaertl
force-pushed
the
fix/avoid-cache-clear
branch
2 times, most recently
from
ae4999b
to
4b5250e
Compare
icewind1991
approved these changes
Mar 6, 2024
nickvergessen
approved these changes
Mar 6, 2024
skjnldsv
force-pushed
the
fix/avoid-cache-clear
branch
from
4b5250e
to
3acf087
Compare
skjnldsv
added
4. to release
Signed-off-by: Julius Härtl <jus@bitgrid.net>
nickvergessen
force-pushed
the
fix/avoid-cache-clear
branch
from
3acf087
to
972a611
Compare
This was referenced Mar 8, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
clearon Redis is a heavy operation and can result in slow queries there. For the reference cache we can avoid in cases we know that we have never set entries with a prefix.One common case is file references where we always called clear on file deletion, share adding/removal even though no references to those files were used.