Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding PublicSectorBundle #44011

Merged
merged 2 commits into from Mar 12, 2024
Merged

Conversation

sorbaugh
Copy link
Contributor

@sorbaugh sorbaugh commented Mar 5, 2024

  • Resolves: # (none)

Summary

This PR adds a new Bundle for public sectorr

TODO

  • Extra approval step -> confirm if app list is final

Checklist

Copy link
Member

@jospoortvliet jospoortvliet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sorbaugh sorbaugh requested a review from blizzz March 6, 2024 16:45
Copy link
Member

@AndyScherzinger AndyScherzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, how about also adding the audit app?

@sorbaugh @jospoortvliet

Copy link
Member

@blizzz blizzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💬

lib/private/App/AppStore/Bundles/PublicSectorBundle.php Outdated Show resolved Hide resolved
@blizzz
Copy link
Member

blizzz commented Mar 6, 2024

Lgtm, how about also adding the audit app?

loosely connected, but would be a reason to consider making https://docs.nextcloud.com/server/latest/admin_manual/configuration_server/logging_configuration.html#log-level-interaction the default, or even enforced. It's a bit counter intuitive in general to switch this one through the log condition, and having audit_log enabled should be already sufficient for logging.

@AndyScherzinger
Copy link
Member

@sorbaugh can you align on #44011 (comment)

Other than that I think the PR is good to go for the moment 👍

@AndyScherzinger
Copy link
Member

Can ship with beta2 as is, so marketing can do their screenshots

@AndyScherzinger AndyScherzinger added this to the Nextcloud 29 milestone Mar 11, 2024
@AndyScherzinger
Copy link
Member

Fine to merge for Rc2 then 👍

@AndyScherzinger AndyScherzinger added the 4. to release Ready to be released and/or waiting for tests to finish label Mar 12, 2024
@Altahrim Altahrim mentioned this pull request Mar 12, 2024
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal changed the title Adding PublicSectorBundle feat: Adding PublicSectorBundle Mar 12, 2024
@Altahrim Altahrim enabled auto-merge March 12, 2024 17:41
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@sorbaugh sorbaugh disabled auto-merge March 12, 2024 18:56
@AndyScherzinger AndyScherzinger merged commit b800de2 into master Mar 12, 2024
157 of 160 checks passed
@AndyScherzinger AndyScherzinger deleted the sorbaugh/public-bundle branch March 12, 2024 18:57
@AndyScherzinger
Copy link
Member

Force merged in alignment with @sorbaugh

@sorbaugh
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants