New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adding PublicSectorBundle #44011
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, how about also adding the audit app?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💬
loosely connected, but would be a reason to consider making https://docs.nextcloud.com/server/latest/admin_manual/configuration_server/logging_configuration.html#log-level-interaction the default, or even enforced. It's a bit counter intuitive in general to switch this one through the log condition, and having audit_log enabled should be already sufficient for logging. |
@sorbaugh can you align on #44011 (comment) Other than that I think the PR is good to go for the moment 👍 |
Can ship with beta2 as is, so marketing can do their screenshots |
Fine to merge for Rc2 then 👍 |
Signed-off-by: Christopher Ng <chrng8@gmail.com>
d3c8e51
to
82a1724
Compare
Signed-off-by: Christopher Ng <chrng8@gmail.com>
3770c9c
to
af49278
Compare
Force merged in alignment with @sorbaugh |
Thanks! |
Summary
This PR adds a new Bundle for public sectorr
TODO
Checklist