feat(files): add Viewer Files ressource handler #44012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Merged
skjnldsv
force-pushed
the
feat/live-file-reference
branch
4 times, most recently
from
efcb9b0
to
0d0cbe3
Compare
skjnldsv
added
3. to review
skjnldsv
requested review from
susnux,
juliushaertl,
max-nextcloud,
artonge and
Pytal
Closed
|
Pushed a small addition to fix other viewer components I've tested (text/files_pdfviewer), hope that is fine |
juliushaertl
approved these changes
Mar 7, 2024
|
AH, I changed the |
|
Ok, I see, I added that for text as we there do not load the file until active is set, but I can work around that in text. |
juliushaertl
reviewed
Mar 7, 2024
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
skjnldsv
force-pushed
the
feat/live-file-reference
branch
from
8a4cb21
to
bebf1e1
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Peek.06-03-2024.18-33.mp4