Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove unused endpoint from base.php #44014

Merged
merged 1 commit into from Mar 6, 2024

Conversation

come-nc
Copy link
Contributor

@come-nc come-nc commented Mar 5, 2024

It’s not called anymore, and app loading cannot break boot anymore

It was added in 1dbe240 but the frontend code calling it was removed long ago. Also it’s pretty hard for an app to break the files app because Throwables at boot are catched.
It’s still possible to crash /app/files by listening to sidebar loading and crashing for instance, and there are some message about it in the UI but it does not seem to disable. This should be fixed in a follow-up and use the standard disable app route.

Checklist

@come-nc come-nc added the 3. to review Waiting for reviews label Mar 5, 2024
@come-nc come-nc added this to the Nextcloud 29 milestone Mar 5, 2024
@come-nc come-nc self-assigned this Mar 5, 2024
It’s not called anymore, and app loading cannot break boot anymore

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can not find any usage of this anymore - moreover I tested to break server core but any bootstraping issue is catched and logged -> faulty apps do not harm the core anymore.

@nickvergessen
Copy link
Member

but the frontend code calling it was removed long ago.

It was called automatically when you enabled an app via the UI that afterwards broke the index.php loading. But yeah might not be needed as much anymore with the register/bootstrap now

@come-nc come-nc merged commit dc67825 into master Mar 6, 2024
160 checks passed
@come-nc come-nc deleted the fix/remove-base-php-unused-endpoint branch March 6, 2024 09:16
@susnux
Copy link
Contributor

susnux commented Mar 6, 2024

It was called automatically when you enabled an app via the UI that afterwards broke the index.php loading

That was missing for couple of years, see #44016

@nickvergessen
Copy link
Member

That was missing for couple of years, see #44016

Well that might not work in most cases, exactly why we had this URL hardcoded to the beginning of the base.php handling so it's done before anything else.

@blizzz blizzz mentioned this pull request Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants