Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(theming): Provide CSS variable for favorite color and adjust for dark mode #44034

Merged
merged 2 commits into from Mar 7, 2024
Merged

feat(theming): Provide CSS variable for favorite color and adjust for dark mode #44034

merged 2 commits into from Mar 7, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Mar 6, 2024

Summary

Provide the favorite color as a CSS variable and adjust it for the dark mode to look a bit nicer (bright mode does not work due to contrast issues).

Screenshot 2024-03-06 at 14-37-04 Files - Nextcloud

Checklist

@susnux susnux added 3. to review Waiting for reviews feature: theming labels Mar 6, 2024
@susnux susnux added this to the Nextcloud 29 milestone Mar 6, 2024
@susnux susnux requested a review from skjnldsv as a code owner March 6, 2024 13:41
@susnux susnux changed the title fix(theming): Provide CSS variable for favorite color and adjust for dark mode feat(theming): Provide CSS variable for favorite color and adjust for dark mode Mar 6, 2024
@susnux susnux added enhancement design Design, UI, UX, etc. labels Mar 6, 2024
szaimen
szaimen approved these changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@szaimen szaimen mentioned this pull request Mar 6, 2024
Merged
4 tasks
@skjnldsv

This comment was marked as resolved.

Sign in to view
@skjnldsv skjnldsv added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Mar 6, 2024
@susnux susnux added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Mar 6, 2024
marcoambrosini
marcoambrosini approved these changes Mar 6, 2024
View reviewed changes
Copy link
Member

@marcoambrosini marcoambrosini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)

@susnux susnux enabled auto-merge March 6, 2024 16:45
@skjnldsv

This comment was marked as resolved.

Sign in to view
@skjnldsv skjnldsv added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Mar 6, 2024
susnux and others added 2 commits March 6, 2024 22:28
@susnux @szaimen
feat(theming): Provide CSS variable for favorite color and adjust for…
4b8868a 
… dark mode

Co-authored-by: Simon L <szaimen@e.mail.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
chore: Compile assets
f3a74c5 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@skjnldsv skjnldsv disabled auto-merge March 7, 2024 10:05
@skjnldsv skjnldsv merged commit 6c04942 into master Mar 7, 2024
158 of 160 checks passed
@skjnldsv skjnldsv deleted the fix/favorite-color branch March 7, 2024 10:06
@blizzz blizzz mentioned this pull request Mar 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@marcoambrosini marcoambrosini marcoambrosini approved these changes

@szaimen szaimen szaimen approved these changes

@JuliaKirschenheuter JuliaKirschenheuter Awaiting requested review from JuliaKirschenheuter

Assignees
No one assigned
Labels
2. developing Work in progress design Design, UI, UX, etc. enhancement feature: theming
Projects
None yet
Milestone
Nextcloud 29
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@susnux @skjnldsv @marcoambrosini @szaimen