fix app management scrolling for Safari/WebKit browsers #44096
Conversation
fix scrolling for Safari-Browser. nextcloud#42249 Signed-off-by: linuzer <github@tscholz.net>
joshtrichards
changed the title
| @@ -210,7 +210,6 @@ export default { | |||
|
|
|||
| .app-name--link::after { | |||
| content: ''; | |||
| position: absolute; | |||
| top: 0; | |||
| left: 0; | |||
| right: 0; | |||
There was a problem hiding this comment.
Removing position: absolute should be together with inset values - top, left etc. They doesn't work for static position. And without absolution position the whole ::after doesn't work, it has no size.
But this pseudo-element ::after was added intentionally. It allowed to click on the table row like it is a link. Without it, you need to click exactly on the text to open sidebar.
If it is removed, we need some alternative here. Or find the reason, why having it breaks Safari. I'll have a look in 2-3 hours on Safari.
There was a problem hiding this comment.
This is a known Safari behavior. According to the standard, position behavior on TR is not defined. While it works fine in other browsers, Safari does not allow to set the position.
There was a problem hiding this comment.
I see what you say, but unfortunately I am not able to provide a better solution.
For the time being until someone finds a better solution or Safari provides a fix, I personally would prefer to have a working app management page with a "too-small" link on the app-name rather than a broken page. But that's just my 2 cents.
There was a problem hiding this comment.
A better solution wasn't simple, especially with some legacy parts of this page.
Thank you for your work on the issue.
There was a problem hiding this comment.
No, thank you for this far better solution! 👍
|
Fixed in #44236 |
fix #42249 scrolling for Safari-Browser.
Checklist