Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable26] fix(UpdateNotifications): Handle numeric user ids #44100

Merged
merged 1 commit into from Mar 9, 2024
Merged

[stable26] fix(UpdateNotifications): Handle numeric user ids #44100

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions apps/updatenotification/lib/Notification/BackgroundJob.php
View file
Open in desktop
Expand Up @@ -113,7 +113,7 @@
->setSubject('connection_error', ['days' => $numDays]);

foreach ($this->getUsersToNotify() as $uid) {
$notification->setUser($uid);
$notification->setUser((string) $uid);

Check notice

Code scanning / Psalm

RedundantCastGivenDocblockType Note

Redundant cast to string given docblock-provided type
$this->notificationManager->notify($notification);
}
} catch (\InvalidArgumentException $e) {
Expand Down Expand Up @@ -181,7 +181,7 @@
}

foreach ($this->getUsersToNotify() as $uid) {
$notification->setUser($uid);
$notification->setUser((string) $uid);

Check notice

Code scanning / Psalm

RedundantCastGivenDocblockType Note

Redundant cast to string given docblock-provided type
$this->notificationManager->notify($notification);
}
} catch (\InvalidArgumentException $e) {
Expand Down