Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: added codespace link #44260

Merged
merged 1 commit into from Mar 19, 2024
Merged

docs: added codespace link #44260

merged 1 commit into from Mar 19, 2024

Conversation

RajeevDash007
Copy link
Contributor

@RajeevDash007
Copy link
Contributor Author

@skjnldsv Please review this

@susnux susnux requested review from a team, Pytal, szaimen and emoral435 and removed request for a team March 17, 2024 18:37
@RajeevDash007
Copy link
Contributor Author

its been approved by 2 reviewers,
I guess, Now its ready to be merged.
I hope, one of the maintainers will merge it

@RajeevDash007 @susnux
docs: added codespace link
e64fee8 
Signed-off-by: Rajeev Lochan Dash <96860040+RajeevDash007@users.noreply.github.com>
@susnux
Copy link
Contributor

susnux commented Mar 18, 2024

I think cypress always fails for forks, so we need the force-merge power of @skjnldsv

@RajeevDash007
Copy link
Contributor Author

RajeevDash007 commented Mar 19, 2024 •
edited

yes @skjnldsv

@skjnldsv skjnldsv merged commit cfca735 into nextcloud:master Mar 19, 2024
96 of 103 checks passed
@welcome Welcome
Copy link

welcome bot commented Mar 19, 2024

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 19, 2024
@Altahrim Altahrim mentioned this pull request Mar 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@szaimen szaimen szaimen approved these changes

@Pytal Pytal Awaiting requested review from Pytal Pytal was automatically assigned from nextcloud/server-frontend

@emoral435 emoral435 Awaiting requested review from emoral435 emoral435 was automatically assigned from nextcloud/server-frontend

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish developer experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add new codespace link to docs
4 participants
@RajeevDash007 @susnux @szaimen @skjnldsv