[stable27] Forbid tagging readonly files #44299
Conversation
![backportbot[bot]](https://avatars.githubusercontent.com/in/60201?s=60&v=4){kind=small}
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc
force-pushed
the
backport/44297/stable27
branch
from
c39e605
to
3b4d5ea
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -60,10 +61,19 @@ | |||
| $tagMapper, | |||
| $userSession, | |||
| $groupManager, | |||
| function ($name) { | |||
| function ($name): bool { | |||
Check notice
Code scanning / Psalm
MissingClosureParamType Note
| $nodes = \OC::$server->getUserFolder()->getById((int)$name); | ||
| return !empty($nodes); | ||
| } | ||
| }, | ||
| function ($name): bool { |
Check notice
Code scanning / Psalm
MissingClosureParamType Note
| } | ||
| }, | ||
| function ($name): bool { | ||
| $nodes = \OC::$server->getUserFolder()->getById((int)$name); |
Check notice
Code scanning / Psalm
DeprecatedMethod Note
| } | ||
| }, | ||
| function ($name): bool { | ||
| $nodes = \OC::$server->getUserFolder()->getById((int)$name); |
Check notice
Code scanning / Psalm
PossiblyNullReference Note
| @@ -77,7 +87,8 @@ | |||
| $tagMapper, | |||
| $userSession, | |||
| $groupManager, | |||
| $entityExistsFunction | |||
| $entityExistsFunction, | |||
| fn ($name) => true, | |||
Check notice
Code scanning / Psalm
MissingClosureParamType Note
|
/backport! to stable26 |
|
/backport! to stable25 |
|
/backport! to stable24 |
|
/backport! to stable23 |
susnux
requested review from
a team,
ArtificialOwl and
sorbaugh
and removed request for
a team
come-nc
added
4. to release
Backport of #44297
Warning, This backport's changes differ from the original and might be incomplete⚠️ Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.