Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dav): Track calendar object changes in admin audit log #44395

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ChristophWurst
Copy link
Member

Summary

Makes it possible for admins to keep a log of (critical) changes in user calendars, e.g. if a suspicious activity has happened.

TODO

  • ...

Checklist

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst self-assigned this Mar 21, 2024
@ChristophWurst ChristophWurst added this to the Nextcloud 30 milestone Mar 21, 2024
/**
* @template-extends IEventListener<CalendarObjectCreatedEvent|CalendarObjectUpdatedEvent|CalendarObjectMovedEvent|CalendarObjectDeletedEvent|Event>
*/
class AdminAuditListener implements IEventListener {

Check failure

Code scanning / Psalm

InvalidDocblock Error

@template-extends must include the name of an extended class, got OCP\EventDispatcher\IEventListener<OCA\DAV\Events\CalendarObjectCreatedEvent|OCA\DAV\Events\CalendarObjectDeletedEvent|OCA\DAV\Events\CalendarObjectMovedEvent|OCA\DAV\Events\CalendarObjectUpdatedEvent|OCP\EventDispatcher\Event>
/**
* @template-extends IEventListener<CalendarObjectCreatedEvent|CalendarObjectUpdatedEvent|CalendarObjectMovedEvent|CalendarObjectDeletedEvent|Event>
*/
class AdminAuditListener implements IEventListener {

Check failure

Code scanning / Psalm

MissingTemplateParam Error

OCA\DAV\Listener\AdminAuditListener has missing template params when extending OCP\EventDispatcher\IEventListener, expecting 1
'Calendar event %s moved from calendar %s of principal %s updated to calendar %s of principal %s',
[
$event->getObjectData()['uri'] ?? '?',
$event->getSourceCalendarData()['uri'] ?? '?',

Check failure

Code scanning / Psalm

UndefinedMethod Error

Method OCA\DAV\Events\CalendarObjectDeletedEvent::getSourceCalendarData does not exist
[
$event->getObjectData()['uri'] ?? '?',
$event->getSourceCalendarData()['uri'] ?? '?',
$event->getSourceCalendarData()['principaluri'] ?? '?',

Check failure

Code scanning / Psalm

UndefinedMethod Error

Method OCA\DAV\Events\CalendarObjectDeletedEvent::getSourceCalendarData does not exist
$event->getObjectData()['uri'] ?? '?',
$event->getSourceCalendarData()['uri'] ?? '?',
$event->getSourceCalendarData()['principaluri'] ?? '?',
$event->getTargetCalendarData()['uri'] ?? '?',

Check failure

Code scanning / Psalm

UndefinedMethod Error

Method OCA\DAV\Events\CalendarObjectDeletedEvent::getTargetCalendarData does not exist
$event->getSourceCalendarData()['uri'] ?? '?',
$event->getSourceCalendarData()['principaluri'] ?? '?',
$event->getTargetCalendarData()['uri'] ?? '?',
$event->getTargetCalendarData()['principaluri'] ?? '?',

Check failure

Code scanning / Psalm

UndefinedMethod Error

Method OCA\DAV\Events\CalendarObjectDeletedEvent::getTargetCalendarData does not exist
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 🏗️ In progress
Development

Successfully merging this pull request may close these issues.

None yet

1 participant