Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(federation): Fix creating local cloudIds with http:// protocol #44453

Merged
merged 1 commit into from Mar 25, 2024

Conversation

nickvergessen
Copy link
Member

Summary

As per the already existing comment in the code:

		// note that for remote id's we don't strip the protocol for the remote we use to construct the CloudId
		// this way if a user has an explicit non-https cloud id this will be preserved
		// we do still use the version without protocol for looking up the display name

However this was not applied correctly when generating a local cloudId with remote === null

Checklist

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the bugfix/noid/fix-cloud-id-generation-with-http branch from 09af86d to dababa5 Compare March 25, 2024 13:22
@nickvergessen nickvergessen merged commit ce059fe into master Mar 25, 2024
167 checks passed
@nickvergessen nickvergessen deleted the bugfix/noid/fix-cloud-id-generation-with-http branch March 25, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants