fix(Router): Stop loading routes of disabled apps

[provokateurin]

Summary

Routes of disabled apps should not be loaded. The classes are not loaded by the autoloader and the request will fail trying to use reflection on them.

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[provokateurin]

/backport to stable29

[provokateurin]

For some reason the comments integration test fails reliably because of 404 instead of 200. Seems like this patch is blocking too much? But if the dashboard app is disabled the test should have never worked.

[nickvergessen]

Let's not backport it to older versions in this case.
29 we can to after the final and patch it locally before hand to get insights

[provokateurin]

I limited the check to the part that is responsible for parsing the attributes as blocking in any case was breaking the comments integration tests (which also seems to be a bug but not in scope of the fix).

[BJKle]

will this be in next release 29.0.1?
because currently my log file gets filled with errors "OCA\UserStatus\Controller\HeartbeatController" whenever someone uses an app.
see: nextcloud/ios#2927

[provokateurin]

Yes, this will appear in 29.0.1

[philippe-ritter]

Hi all,
even with version 29.0.1, and I checked in Router.php that I have the latest change, I got this error :
"reqId": "Zl9qwRitzrnfd2ZKakQ-gAAAA1I",
"level": 3,
"time": "2024-06-04T19:28:01+00:00",
"remoteAddr": "",
"user": "phr",
"app": "core",
"method": "GET",
"url": "/Nuage/index.php/apps/files/",
"message": "Exception thrown: ReflectionException",
"userAgent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/125.0.0.0 Safari/537.36",
"version": "29.0.1.1",
"exception": {
"Exception": "ReflectionException",
"Message": "Class "OCA\Files\Controller\AjaxController" does not exist",
"Code": -1,
"Trace": [
{
"file": "/home/clients/659aacf688b6ffdff44c2c628e43d209/web/famille-ritter.ch/Nuage/lib/private/Route/Router.php",
"line": 469,
"function": "__construct",
"class": "ReflectionClass",
"type": "->",
"args": [
"OCA\Files\Controller\AjaxController"
]
},

What could cause this error ?

[philippe-ritter]

Ok, I found my problem :
ls -l
total 64
-rw-r--r-- 1 uid121945 ldapusers 1624 Mar 23 2023 AjaxController.php
-rw-r--r-- 1 uid121945 ldapusers 11872 May 23 15:16 ApiController.php
-rw-r--r-- 1 uid121945 ldapusers 6353 May 23 15:16 DirectEditingController.php
-rw-r--r-- 1 uid121945 ldapusers 2018 May 23 15:16 DirectEditingViewController.php
-rw-r--r-- 1 uid121945 ldapusers 4900 May 23 15:16 OpenLocalEditorController.php
-rw-r--r-- 1 uid121945 ldapusers 3793 May 23 15:16 TemplateController.php
-rw-r--r-- 1 uid121945 ldapusers 7429 May 23 15:16 TransferOwnershipController.php
-rw-r--r-- 1 uid121945 ldapusers 13146 May 23 15:16 ViewController.php

I had a really old file in my files app, which was still loaded I think
Now after deleting it, it's working again !

[provokateurin]

Yeah I was about to say that this file doesn't even exist anymore in the codebase 🙈