fix(federation): re-add RequestSharedSecret job if necessary #44848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fighting another race condition with federated server setup Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
blizzz
requested review from
nickvergessen,
Fenn-CS,
a team,
ArtificialOwl and
yemkareems
and removed request for
a team
Fenn-CS
approved these changes
Apr 16, 2024
|
|
||
| $hasJob = false; | ||
| foreach ($this->jobList->getJobsIterator(RequestSharedSecret::class, 1, 0) as $job) { | ||
| $hasJob = true; |
There was a problem hiding this comment.
but this could be for another URL?
There was a problem hiding this comment.
Ah, good point. Shall compare that argument then.
There was a problem hiding this comment.
And then either loop over all or get chunks until you found it
There was a problem hiding this comment.
Yes. I would have looked for the hasJob, but the timestamp ruins it.
blizzz
added
2. developing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fighting another race condition with federated server setup
Summary
@Fenn-CS and I saw another race condition when trying to set up trusted servers. Even when running cron-jobs hand-pickedly, we could end up in state where the
requestSharedSecretendpoint is called, claims to We will initiate the exchange of the shared secret, but does not have the appropriate Job in its list anymore.The change queries the joblist to see whether this one is actually scheduled, and adds it back if it is not the case.
Checklist