Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix truncation on public page #44923

Merged
merged 2 commits into from Apr 23, 2024
Merged

fix: Fix truncation on public page #44923

merged 2 commits into from Apr 23, 2024

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Apr 18, 2024

Summary

Before After
image image

Checklist

@Pytal Pytal added bug design Design, UI, UX, etc. 3. to review Waiting for reviews labels Apr 18, 2024
@Pytal Pytal added this to the Nextcloud 30 milestone Apr 18, 2024
@Pytal Pytal self-assigned this Apr 18, 2024
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should actually be a subline of the title on the left, instead of being pushed to the right. Must have regressed at some point?

@Pytal Pytal added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Apr 23, 2024
@Pytal Pytal marked this pull request as draft April 23, 2024 00:04
@Pytal Pytal force-pushed the fix/public-share-truncation branch from da3310f to d3ef076 Compare April 23, 2024 01:28
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal force-pushed the fix/public-share-truncation branch from d3ef076 to f01b80e Compare April 23, 2024 01:30
@Pytal Pytal marked this pull request as ready for review April 23, 2024 01:32
@Pytal Pytal added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Apr 23, 2024
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @Pytal! :)
Just to be sure – this will then also work on public pages of apps which don’t have a subline, right? (So that the main line is just vertically aligned correctly, and not up top.)

@Pytal
Copy link
Member Author

Pytal commented Apr 23, 2024

Looks great, thanks @Pytal! :) Just to be sure – this will then also work on public pages of apps which don’t have a subline, right? (So that the main line is just vertically aligned correctly, and not up top.)

Yes, without the subline the main line will still be vertically aligned :)

@Pytal Pytal merged commit 5b85562 into master Apr 23, 2024
160 of 161 checks passed
@Pytal Pytal deleted the fix/public-share-truncation branch April 23, 2024 17:17
@Pytal
Copy link
Member Author

Pytal commented Apr 23, 2024

/backport to stable29

@Pytal
Copy link
Member Author

Pytal commented Apr 23, 2024

/backport to stable28

@Pytal
Copy link
Member Author

Pytal commented Apr 23, 2024

/backport to stable27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug design Design, UI, UX, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Title on public pages is truncated
4 participants