Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(userstatus): catch unique constrain violation on revert #45055

Merged
merged 1 commit into from
May 6, 2024

Conversation

miaulalala
Copy link
Contributor

@miaulalala miaulalala commented Apr 26, 2024

Summary

If during the revert of a status another operation wrote an additional status, the operation will fail with a unique constraint violation. Since we cannot determine which status is valid, we catch the exception and silently drop the revert.

Checklist

@miaulalala miaulalala added the 2. developing Work in progress label Apr 26, 2024
@miaulalala miaulalala self-assigned this Apr 26, 2024
@miaulalala miaulalala added 3. to review Waiting for reviews bug and removed 2. developing Work in progress labels Apr 26, 2024
@miaulalala
Copy link
Contributor Author

/backport to stable29

@miaulalala
Copy link
Contributor Author

/backport to stable28

@miaulalala miaulalala requested review from a team, ArtificialOwl, yemkareems and sorbaugh and removed request for a team April 26, 2024 13:08
Signed-off-by: Anna Larch <anna@nextcloud.com>
@miaulalala miaulalala enabled auto-merge May 6, 2024 15:08
@miaulalala miaulalala force-pushed the fix/revert-user-status-exception branch from c39765d to e43811d Compare May 6, 2024 15:08
@miaulalala miaulalala merged commit a40a13c into master May 6, 2024
157 checks passed
@miaulalala miaulalala deleted the fix/revert-user-status-exception branch May 6, 2024 16:31
@solracsf
Copy link
Member

solracsf commented May 6, 2024

Backport to 27? #42625 (comment)

@blizzz blizzz mentioned this pull request Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants