Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dav): Try basic auth for ajax WebDAV requests #45207

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

susnux
Copy link
Contributor

@susnux susnux commented May 6, 2024

Summary

Allow using basic auth with ajax requests on WebDAV.
The idea why the code was added in the first place was to ensure that if basic auth fails the user gets not asked by the browser for the correct credentials.
We still keep this behavior by throwing a 401 error in case of failed basic auth.

Checklist

@susnux susnux added this to the Nextcloud 30 milestone May 6, 2024
@susnux
Copy link
Contributor Author

susnux commented May 7, 2024

The problem gets visible because previous versions of @nextcloud/axios were not setting the header, but the latest version will set the X-Requested-With header by default.

Meaning the alternative to this is to drop the X-Requested-With: XMLHttpRequest from axios requests to DAV like we were doing with current versions (currently we do not set X-Requested-With for ajax requests to DAV to prevent this.
So I think this solution here is cleaner than faking the kind of request 😅

apps/dav/tests/unit/Connector/Sabre/AuthTest.php Outdated Show resolved Hide resolved
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking temporarily

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants