fix(db): Prevent data loss by temporarily disabling db:convert-type
#45400
+7
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WARNING: Needed until #45257 is addressed to prevent data loss
Summary
Currently the bug described in #45257 (and related #45097) has a serious side effect/interaction with the
occ db:convert-type
command which results in dropping the source database.Based on preliminary analysis, this is likely a bug arising from changes made in #41998 that were released as part of 29.0.0.
If we're unable to address #45257 prior to the release of 29.0.1 in a few days, then I propose we disable
occ db:convert-type
temporarily (hopefully just until the next maintenance release) rather than risk people wiping out their database. That is the purpose of this PR.This is a backup PR which I propose merging in
master
and backporting to 29.0.1 prior to it being published if necessary.If it turns out to be unnecessary, all the better.
TODO
Checklist