Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show non writable folders during move or copy #45688

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

artonge
Copy link
Contributor

@artonge artonge commented Jun 6, 2024

With ACL, a groupfolders might be non-writable but still contain writable sub folders.

  • Disable the submit button when we are in a non-writable folder @susnux or @skjnldsv, could one of you look into that?

Fix #44649
Fix nextcloud/groupfolders#2771
Fix nextcloud/groupfolders#2926

@artonge artonge requested a review from skjnldsv as a code owner June 6, 2024 09:36
@artonge artonge requested a review from susnux June 6, 2024 09:37
@artonge artonge self-assigned this Jun 6, 2024
@artonge artonge added the 3. to review Waiting for reviews label Jun 6, 2024
@artonge artonge added this to the Nextcloud 30 milestone Jun 6, 2024
@artonge
Copy link
Contributor Author

artonge commented Jun 6, 2024

/backport to stable29

@artonge
Copy link
Contributor Author

artonge commented Jun 6, 2024

/backport to stable28

@artonge artonge force-pushed the artonge/fix/show_non_writable_folders branch from 2503fc7 to 580352a Compare June 6, 2024 09:39
@artonge artonge force-pushed the artonge/fix/show_non_writable_folders branch from 580352a to 89fe537 Compare June 6, 2024 09:54
.htaccess Outdated Show resolved Hide resolved
@susnux
Copy link
Contributor

susnux commented Jun 7, 2024

[ ] Disable the submit button when we are in a non-writable folder @susnux or @skjnldsv, could one of you look into that?

Doable with a small library change, I can do so.

@susnux
Copy link
Contributor

susnux commented Jun 8, 2024

Doable with a small library change, I can do so.

@artonge we need the library change, but you can already change it in this PR:
Simply in the button facatory (next lines) add to each button:
disabled: _selection.some((node) => node.permissions & Permission.CREATE) === 0)

(better also rename _selection to remove the _)

@artonge
Copy link
Contributor Author

artonge commented Jun 10, 2024

Simply in the button facatory (next lines) add to each button:
disabled: _selection.some((node) => node.permissions & Permission.CREATE) === 0)

Don't we want to check the current folder's permissions instead of the selected nodes' permissions?

@artonge artonge force-pushed the artonge/fix/show_non_writable_folders branch from 89fe537 to 8452ba7 Compare June 10, 2024 07:46
@susnux
Copy link
Contributor

susnux commented Jun 10, 2024

Don't we want to check the current folder's permissions instead of the selected nodes' permissions?

We want to ensure the picked folder has permissions, so checking the selected node is the way to go :)
This already works (but will probably be false positive until we update the dialogs library)

@artonge artonge force-pushed the artonge/fix/show_non_writable_folders branch from 8452ba7 to a058643 Compare June 10, 2024 14:25
@artonge
Copy link
Contributor Author

artonge commented Jun 10, 2024

@susnux susnux force-pushed the artonge/fix/show_non_writable_folders branch from a058643 to 7475857 Compare June 12, 2024 09:43
@susnux
Copy link
Contributor

susnux commented Jun 12, 2024

Rebased with the required library changes.

@susnux susnux added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jun 12, 2024
@susnux susnux force-pushed the artonge/fix/show_non_writable_folders branch from 7475857 to 62724ca Compare June 12, 2024 11:16
@susnux susnux force-pushed the artonge/fix/show_non_writable_folders branch 2 times, most recently from 87d3b8e to b9b5ab4 Compare June 12, 2024 21:04
@artonge artonge force-pushed the artonge/fix/show_non_writable_folders branch from b9b5ab4 to 36aa75f Compare June 13, 2024 08:28
This was referenced Jun 13, 2024
@artonge
Copy link
Contributor Author

artonge commented Jun 13, 2024

Two pending issues:

  • It is not possible to navigate to a folder in the file picker
  • Right-clicking on a file in the files list triggers the default action.

@artonge artonge force-pushed the artonge/fix/show_non_writable_folders branch from 36aa75f to 38919a0 Compare June 13, 2024 14:10
@artonge

This comment was marked as outdated.

@artonge

This comment was marked as outdated.

@artonge

This comment was marked as resolved.

This comment was marked as resolved.

@blizzz blizzz force-pushed the artonge/fix/show_non_writable_folders branch from 38919a0 to 4e733e4 Compare June 14, 2024 08:59
@blizzz
Copy link
Member

blizzz commented Jun 14, 2024

rebased and commit results of npm ci && npm run build && npm run postbuild 🍀

@artonge artonge force-pushed the artonge/fix/show_non_writable_folders branch from 4e733e4 to 7ab40a9 Compare June 19, 2024 13:59
@artonge
Copy link
Contributor Author

artonge commented Jun 19, 2024

/compile /

Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge artonge force-pushed the artonge/fix/show_non_writable_folders branch from 004e9c0 to ae0106e Compare June 19, 2024 15:40
@artonge artonge enabled auto-merge June 19, 2024 16:35
@artonge artonge merged commit bea9dae into master Jun 20, 2024
110 checks passed
@artonge artonge deleted the artonge/fix/show_non_writable_folders branch June 20, 2024 10:16

This comment was marked as outdated.

This comment was marked as outdated.

Copy link

backportbot bot commented Jun 20, 2024

The backport to stable29 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable29
git pull origin stable29

# Create the new backport branch
git checkout -b backport/45688/stable29

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick ae0106ef

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/45688/stable29

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish backport-request bug feature: files javascript
Projects
None yet
4 participants