Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable29] fix(files): handling numbered type owner name & id #45764

Merged

Conversation

sanskar-soni-9
Copy link
Contributor

@sanskar-soni-9 sanskar-soni-9 commented Jun 10, 2024

Summary

Handles numbered 'owner-id' and 'owner-display-name'

Before

240610_19h37m29s_screenshot

After

240610_19h33m51s_screenshot

Checklist

@kesselb kesselb requested review from susnux and artonge June 10, 2024 14:57
@kesselb kesselb added bug 2. developing Work in progress labels Jun 10, 2024
@kesselb kesselb added this to the Nextcloud 30 milestone Jun 10, 2024
@susnux susnux changed the title fix(files): handling numbered type owner name & id [stable29] fix(files): handling numbered type owner name & id Jun 11, 2024
@susnux
Copy link
Contributor

susnux commented Jun 11, 2024

/backport to stable28

@susnux susnux requested a review from Pytal June 11, 2024 19:31
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed on master but on stable29 and stable28 we need this.
Thank you.

@susnux susnux added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jun 11, 2024
Signed-off-by: Sanskar Soni <sanskarsoni300@gmail.com>
Comment on lines +69 to +70
'owner-id': owner,
'owner-display-name': String(props['owner-display-name']),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That should not be needed 🤔

Copy link
Member

@skjnldsv skjnldsv Jun 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see we made some mistake and used it in a few locations, I would suggest we fix the usage instead of providing owner-id as extra attributes 🤔

owner-display-name on the other hand is fine I think

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, we fixed it for NC30 and above, I think we can merge for older branches as a safety measure.
I'll create a PR for master 🚀

@skjnldsv skjnldsv merged commit 10f306b into nextcloud:stable29 Jun 12, 2024
95 of 102 checks passed
Copy link

welcome bot commented Jun 12, 2024

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@skjnldsv
Copy link
Member

skjnldsv commented Jun 12, 2024

/backport to stable28

(force recreate)

Copy link

backportbot bot commented Jun 12, 2024

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b backport/45764/stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick d78d468b

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/45764/stable28

Error: Failed to create pull request: Validation Failed: {"resource":"PullRequest","code":"custom","message":"A pull request already exists for nextcloud:backport/45764/stable28."}


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish backport-request bug feedback-requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Numerical accounts show all files/folders in "Shared" status in the web UI
5 participants