Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable28] fix(settings): define a 'heartbeat' route, so SecurityHeaders can handle redirected root #45955

Merged
merged 2 commits into from
Jul 10, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Jun 18, 2024

Backport of PR #45228

@skjnldsv skjnldsv mentioned this pull request Jun 20, 2024
6 tasks
@blizzz blizzz mentioned this pull request Jun 21, 2024
@blizzz blizzz mentioned this pull request Jun 25, 2024
@MichaIng
Copy link
Member

Is this route actually used in NC28?

The security headers check was migrated in NC29. Previously OC.generateUrl('heartbeat') was used.

@come-nc
Copy link
Contributor

come-nc commented Jul 1, 2024

Is this route actually used in NC28?

The security headers check was migrated in NC29. Previously OC.generateUrl('heartbeat') was used.

It’s cleaner to have the route in the system since it exists. And if the migration of the check is ever backported we won’t get a bug from it.

@come-nc come-nc added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 8, 2024
@Altahrim Altahrim mentioned this pull request Jul 10, 2024
smokris and others added 2 commits July 10, 2024 14:38
…dle redirected root

Signed-off-by: Steve Mokris <steve@kosada.com>
Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com>
Signed-off-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
@kesselb
Copy link
Contributor

kesselb commented Jul 10, 2024

Pushed b5cf099 to fix the failing test.

The router uses include_once to load route definitions from the apps.

First include_once for apps/files/appinfo/routes.php returns the expected array.

Second include_once returns true, because the file was already included.

To workaround the tests must run in a separate process.

I have no idea why the test is not failing on master.

@kesselb
Copy link
Contributor

kesselb commented Jul 10, 2024

To workaround the tests must run in a separate process.

That does not seem to work

I have no idea why the test is not failing on master.

The test is not failing on master because the app manager instance is mocked, the app path is null and the routing file not even included: #46416

@AndyScherzinger AndyScherzinger merged commit e319057 into stable28 Jul 10, 2024
96 of 105 checks passed
@AndyScherzinger AndyScherzinger deleted the backport/45228/stable28 branch July 10, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: settings feedback-requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants