Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't trigger action when renaming #45984

Merged
merged 2 commits into from
Jun 20, 2024
Merged

Don't trigger action when renaming #45984

merged 2 commits into from
Jun 20, 2024
+12 −3

Conversation

artonge
Copy link
Contributor

@artonge artonge commented Jun 19, 2024 •
edited

@artonge artonge requested a review from skjnldsv as a code owner June 19, 2024 14:46
@artonge artonge self-assigned this Jun 19, 2024
@artonge artonge added this to the Nextcloud 30 milestone Jun 19, 2024
@artonge artonge requested a review from susnux June 19, 2024 14:46
@artonge artonge force-pushed the artonge/fix/click_while_renaming branch from 3ff6a1c to 9b17c1f Compare June 19, 2024 15:10
@artonge artonge mentioned this pull request Jun 20, 2024
Closed
8 tasks
@artonge
fix(files): Don't react to clicks when renaming
8e0be0a 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge artonge force-pushed the artonge/fix/click_while_renaming branch from 9b17c1f to 8e0be0a Compare June 20, 2024 14:19
@artonge
Copy link
Contributor Author

artonge commented Jun 20, 2024

/compile /

@artonge artonge enabled auto-merge June 20, 2024 14:22
@nextcloud-command
chore(assets): Recompile assets
a6de33b 
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jun 20, 2024
@artonge artonge merged commit 9c4b959 into master Jun 20, 2024
107 of 110 checks passed
@artonge artonge deleted the artonge/fix/click_while_renaming branch June 20, 2024 15:49
@artonge
Copy link
Contributor Author

artonge commented Jun 20, 2024

/backport 8e0be0a to stable29

@artonge
Copy link
Contributor Author

artonge commented Jun 20, 2024

/backport 8e0be0a to stable28

@backportbot backportbot bot mentioned this pull request Jun 20, 2024
Open
1 task
@backportbot backportbot bot mentioned this pull request Jun 20, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

Assignees

@artonge artonge

Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: files javascript
Projects
None yet
Milestone
Nextcloud 30
Development

Successfully merging this pull request may close these issues.

[Bug]: rename file action is not possible and loads document instead
4 participants
@artonge @susnux @skjnldsv @nextcloud-command